Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Added missing xtest #2550

Conversation

DerSimeon
Copy link
Contributor

Added xtest to the knapsack exercise at it was missing. Now all the current exercises are consistent

Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Oct 25, 2024
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@SleeplessByte SleeplessByte reopened this Oct 25, 2024
@SleeplessByte SleeplessByte added the x:size/small Small amount of work label Oct 25, 2024
@SleeplessByte SleeplessByte added hacktoberfest Hacktoberfest issues! Everyone allowed <3 hacktoberfest-accepted Opt-in to hacktoberfest labels Oct 25, 2024
@SleeplessByte SleeplessByte merged commit d1bbdef into exercism:main Oct 25, 2024
9 checks passed
@DerSimeon DerSimeon deleted the fix/knapsack-xtest-fix branch October 26, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest Hacktoberfest issues! Everyone allowed <3 hacktoberfest-accepted Opt-in to hacktoberfest x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants