-
-
Notifications
You must be signed in to change notification settings - Fork 617
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instructions and test case description #2202
Conversation
Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed. That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
(Have not forgotten about this! I'll try to go through this this week <3) |
@SleeplessByte did you ever get chance to take a look at this? |
@alexmitchelldev apologies. Short explanation at the end of this post https://forum.exercism.org/t/issue-with-local-jest-type-definitions-yarn-3-and-jest/6867/24 @ErikSchierboom @junedev @tejasbubane any of you time to check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could of small suggestions.
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
Co-authored-by: Erik Schierboom <[email protected]>
@ErikSchierboom sorry about the glacial response time. I have committed your suggestions. |
Thanks! |
Resolves #1818
Updated instructions.md to be less 'technical' and feel more part of the story. I also updated the test case description for the orderFromGrocer function to properly reflect the function name and arguments passed.