Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct a bank-account test to close account #2062

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

itsjustaaron
Copy link

The test that checks "close already closed account throws error" does not currently try to close the account twice. Adding in account.close() before the expect() should fix this.

The test that checks "close already closed account throws error"  does not currently try to close the account twice. Adding in `account.close()` before the `expect()` should fix this.
@github-actions
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 31, 2023
@SleeplessByte SleeplessByte reopened this Feb 1, 2023
@SleeplessByte
Copy link
Member

As you know from the forum post, we're discussing how to resolve this.

I did want to re-open this to show you that we currently have CI running on each exercise, on each test. If a test is changed, almost always the "proof" also needs to be updated.

The proof lives here: https://github.com/exercism/javascript/blob/main/exercises/practice/bank-account/.meta/proof.ci.js

If we're changing the test to only throw on the "second" close, then we must update the solution to be "open by default", which may or may not be what we want to do, depending on the outcome of the forum post.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants