Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queen-attack to be clearer for non-chess players #1681

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mahmoud-moursy
Copy link

  • Added examples
  • Added explanation for why the queens are labelled B and W

- Added examples
- Added explanation for why the queens are labelled B and W
@github-actions
Copy link
Contributor

Dear T-O-R-U-S

Thank you for contributing to the JavaScript track on Exercism! 💙
You will see some automated feedback below 🤖. It would be great if you can make sure your PR covers those points. This will save your reviewer some time and your change can be merged quicker.

  • ⬆️ The instructions and test cases for many practice exercises originate in the Exercism-wide problem-specifications repo. If the exercise you changed is listed there in the exercises folder, please consider the following.

    • Improvements to the instructions.md file should be made in the problem-spec repo so that all tracks can benefit.
      You can open a PR there instead.
    • If you want to add some language specific information, use the instructions.append.md file (see Practice Exercise Docs).
    • Test cases selected in the .meta/tests.toml file need to be implemented in the <exercise>.spec.js file according to the specification in canonical-data.json.
  • ✍️ If your PR is not related to an existing issue (and is not self-explaining like a typo fix), please make sure the description explains why the change you made is necessary.

  • 🔤 If your PR fixes an easy to identify typo, if would be great if you could check for that typo in the whole repo. For example, if you found Unicdoe, use "replace all" in your editor (or command line magic) to fix it consistently.

Dear Reviewer/Maintainer

  • 📏 Make sure you set the appropriate x:size label for the PR. (This also works after merging, in case you forgot about it.)

  • 🔍 Don't be too nit-picky. If the PR is a clear improvement compared to the status quo, it should be approved as clear signal this is good to be merged even if the minor comments you might have are not addressed by the contributor. Further improvement ideas can be captured in issues (if important enough) and implemented via additional PRs.

  • 🤔 After reviewing the diff in the "Files changed" section, take a moment to think about whether there are changes missing from the diff. Does something need to be adjusted in other places so the code or content stays consistent?

Automated comment created by PR Commenter 🤖.

@SleeplessByte
Copy link
Member

Thank you for your submission. These seem very sensible changes.

The description for this exercise is sourced from https://github.com/exercism/problem-specifications/blob/main/exercises/queen-attack/description.md. Would you be so kind to open a PR in that repo so we can determine if this change is nice for all tracks!

Then, we can come back to this PR and actually pull it from there.

@junedev
Copy link
Member

junedev commented Feb 18, 2022

@SleeplessByte FYI The issue author already did that: exercism/problem-specifications#1965

@SleeplessByte
Copy link
Member

It didn't show up in my notifications list 😅 .

Let's see what happens there 🗡️

@junedev junedev marked this pull request as draft July 17, 2022 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants