Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Concept Exercise: Freelancer Rates #1472

Merged
merged 83 commits into from
Nov 10, 2021
Merged

Improve Concept Exercise: Freelancer Rates #1472

merged 83 commits into from
Nov 10, 2021

Conversation

JaPrad
Copy link
Contributor

@JaPrad JaPrad commented Oct 30, 2021

As discussed in #1049, in this PR I've:

  1. Rearranged and simplified tasks for the ease of learning and updated files accordingly
  2. Introduced the use of remainder operator and modified design.md accordingly
  3. Shown the use of Math.ceil and Math.floor in introduction.md

@JaPrad JaPrad marked this pull request as ready for review November 9, 2021 11:04
@JaPrad JaPrad changed the title Improving Freelancer rates exercise Improve Concept Exercise: Freelancer Rates Nov 10, 2021
@JaPrad JaPrad marked this pull request as draft November 10, 2021 06:40
@JaPrad JaPrad marked this pull request as ready for review November 10, 2021 15:02
@JaPrad
Copy link
Contributor Author

JaPrad commented Nov 10, 2021

Thank you for reviewing @junedev! I've incorporated all of your suggestions.

@JaPrad JaPrad requested a review from junedev November 10, 2021 15:03
@junedev
Copy link
Member

junedev commented Nov 10, 2021

@JaPatGitHub Thanks a lot for your ongoing effort to improve this exercise!

The rounding section still had some typos that I fixed and I changed it so the link is on rounding and not on Math. In about.md I moved the content to the "Built-In object" section since Math is already mentioned there. See 98c7a70. Hope thats ok for you.

@junedev junedev added the x:size/medium Medium amount of work label Nov 10, 2021
@junedev junedev merged commit b7da090 into exercism:main Nov 10, 2021
@SleeplessByte
Copy link
Member

(love this!!)

@JaPrad
Copy link
Contributor Author

JaPrad commented Nov 11, 2021

My pleasure to work with you guys on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest x:size/medium Medium amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants