Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created arithmetic operators concept, as per #1049 #1420

Merged
merged 34 commits into from
Oct 12, 2021
Merged

Created arithmetic operators concept, as per #1049 #1420

merged 34 commits into from
Oct 12, 2021

Conversation

JaPrad
Copy link
Contributor

@JaPrad JaPrad commented Oct 9, 2021

Part of #1049

Copy link
Member

@junedev junedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done overall, thanks a lot! I left some ideas for improvements. I mostly commented on the about.md file but if you fix something there, it might also need to be fixed in the introduction file.

concepts/arithmetic-operators/about.md Outdated Show resolved Hide resolved
concepts/arithmetic-operators/about.md Outdated Show resolved Hide resolved
concepts/arithmetic-operators/about.md Outdated Show resolved Hide resolved
concepts/arithmetic-operators/about.md Outdated Show resolved Hide resolved
concepts/arithmetic-operators/about.md Outdated Show resolved Hide resolved
concepts/arithmetic-operators/links.json Outdated Show resolved Hide resolved
config.json Outdated Show resolved Hide resolved
concepts/arithmetic-operators/introduction.md Outdated Show resolved Hide resolved
@JaPrad JaPrad marked this pull request as draft October 10, 2021 16:04
@JaPrad JaPrad marked this pull request as ready for review October 11, 2021 06:36
@JaPrad JaPrad requested a review from junedev October 11, 2021 06:37
@JaPrad
Copy link
Contributor Author

JaPrad commented Oct 11, 2021

Thank you for reviewing @junedev. I've incorporated your improvement suggestions.

@junedev
Copy link
Member

junedev commented Oct 12, 2021

@JaPatGitHub Thanks for the update! I made some more minor adjustments here b69cb1c.

Some general points to be aware of going forward:

I also added your new content to the exercise introduction so we don't forget about that.

@junedev junedev added hacktoberfest-accepted Opt-in to hacktoberfest x:size/medium Medium amount of work labels Oct 12, 2021
@junedev junedev merged commit 7399efb into exercism:main Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Opt-in to hacktoberfest x:size/medium Medium amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants