Add concept exercise objects #1160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
junedev
commented
Jun 2, 2021
SaschaMann
reviewed
Jun 18, 2021
Co-authored-by: Derk-Jan Karrenbeld <[email protected]> Co-authored-by: Sascha Mann <[email protected]>
@SleeplessByte No need to spare me. 😉 I addressed the existing comments by you and Sascha. Do you want to also review the rest? |
SaschaMann
approved these changes
Jun 21, 2021
|
(turns out I still have some sort of access to this repo, so this appears to be mergeable now, but it's probably best to wait for DJ's approval anyway. I meant to approve in the sense that my comments have all been addressed.) |
SleeplessByte
approved these changes
Jun 22, 2021
Co-authored-by: Derk-Jan Karrenbeld <[email protected]>
|
@SleeplessByte I fixed all the things besides the "you" issue, see comment. |
ErikSchierboom
added
x:size/large
This was referenced Jul 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #993
This one was harder than the others ones. I feel it could still need some more work (left some notes in design.md) but I want to get it out of the door. Hope it is ok for now.