Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v3] Add prerequisites 3/6 #984

Open
TomPradat opened this issue Feb 15, 2021 · 12 comments
Open

[v3] Add prerequisites 3/6 #984

TomPradat opened this issue Feb 15, 2021 · 12 comments
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. help wanted v3-migration 🤖 Preparing for Exercism v3 x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:size/medium Medium amount of work x:type/content Work on content (e.g. exercises, concepts)

Comments

@TomPradat
Copy link
Contributor

TomPradat commented Feb 15, 2021

⚠️ If you have issues / are unsure, create ONE PR PER EXERCISE so it's easier to merge them as we can have discussions per exercise. If you're certain, it's fine to do a single one.

The idea is to split #960 into smaller chunks.

Here is the list of practices exercises to deal with for this part :

anagram

acronym

high-scores

isogram

matching-brackets

phone-number

scale-generator

series

largest-series-product

transpose

grep

rectangles

spiral-matrix

ocr-numbers

saddle-points

forth

food-chain

house

isbn-verifier

pig-latin
@SleeplessByte SleeplessByte added chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. v3-migration 🤖 Preparing for Exercism v3 help wanted labels Feb 26, 2021
@SleeplessByte SleeplessByte added x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:size/medium Medium amount of work x:type/content Work on content (e.g. exercises, concepts) labels Sep 4, 2021
@AnishDe12020
Copy link
Contributor

I am willing to take this issue up (at least some of the exercises). Just let me know if I should make the PRs, one for each exercises, one for a batch of exercises or one for all of them.

@TomPradat
Copy link
Contributor Author

TomPradat commented Dec 2, 2021

I'd suggest that you make a PR for each exercise but if you feel like you want to do a lot of exercises you can take 4-5 by PR.

Trying to do all of them at once is not a good idea IMO, it's indigestible for both you and the reviewer.

Idk if this might help but here are the steps I used when doing some :

1 - Doing/trying the exercise
2 - Looking at the exercise's proof of work
3 - Looking at the submitted solutions.
4 - Adding the prerequisites

@junedev
Copy link
Member

junedev commented Dec 2, 2021

Good advice from @TomPradat there. I am in favor of a batch of max. 5 exercises per PR.

@AnishDe12020
Copy link
Contributor

I'd suggest that you make a PR for each exercise but if you feel like you want to do a lot of exercises you can take 4-5 by PR.

Trying to do all of them at once is not a good idea IMO, it's indigestible for both you and the reviewer.

Idk if this might help but here are the steps I used when doing some :

1 - Doing/trying the exercise 2 - Looking at the exercise's proof of work 3 - Looking at the submitted solutions. 4 - Adding the prerequisites

Sounds good to me

@TomPradat
Copy link
Contributor Author

TomPradat commented Oct 25, 2022

Here is an updated list (25/10/2022) :

  • matching-brackets

  • scale-generator

  • series

  • largest-series-product

  • transpose

  • grep

  • rectangles

  • spiral-matrix

  • ocr-numbers

  • saddle-points

  • forth

  • food-chain

  • house

  • isbn-verifier

  • pig-latin

@safwansamsudeen
Copy link
Contributor

Is this still open? Would love to work on it if it is!

@TomPradat
Copy link
Contributor Author

@safwansamsudeen Yes ! See #984 (comment) for suggestions on how to do it. Let me know if you have any questions

@junedev
Copy link
Member

junedev commented Apr 15, 2023

@safwansamsudeen If you work on this, please start out with a small batch, e.g. 3 exercises max.
Add a GitHub comment for each one explaining which solution you had in mind when selecting the concepts you listed. Maybe paste a link to a community solution or paste some code. This is the only way the PR becomes reviewable. Without this, the reviewer needs to do the exact work you did to come up with the list again to verify it makes sense.

@junedev
Copy link
Member

junedev commented Apr 15, 2023

@TomPradat Please keep this in mind https://exercism.org/blog/freeing-our-maintainers and that neither JD not me are currently actively maintaining this repo. Only encourage community contributions if you are confident that you have the time to properly review them when they come in. Otherwise it will be a frustrating experience for everyone.

@safwansamsudeen
Copy link
Contributor

@junedev I'm new to both OSS and Exercism, so I think I'll start off with one exercise per PR.

@TomPradat, I've currently opened a PR - #2159 - for the House exercise. Let me know how it goes!

@TomPradat
Copy link
Contributor Author

@safwansamsudeen I'll have a look next week when I have a bit more time 👍

@safwansamsudeen
Copy link
Contributor

@TomPradat, just a reminder about the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore 🔧 Meta related task such as build, test, linting, maintainers.json etc. help wanted v3-migration 🤖 Preparing for Exercism v3 x:action/improve Improve existing functionality/content x:knowledge/elementary Little Exercism knowledge required x:size/medium Medium amount of work x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

No branches or pull requests

5 participants