CI does not run at all for some PRs

[junedev]

Lately, for some PRs CI does not run at all for whatever reason.

Example (#1663):

Notice that it says "Checks 0" at the top.

When I close and open the PR, CI is triggered, all checks run as they should:

We also saw this happening on PRs when someone executed the format action via GitHub. CI was not triggered after that change was added.

[theomelo]

@junedev is this issue still happening?

[junedev]

@theomelo I think so but I have not tried recently.

[theomelo]

I could try creating a few PRs to try to reproduce this issue and report back 👍

[theomelo]

Based on your screenshots, I'm assuming there has been a few changes in the actions setup since the creation of this issue. For example, all PRs are now being annotated by pr-commenter.

After I created a couple of PRs (#1994 and #1997), both of them triggered just one action (the pre-comment). The other actions seem only to run after a maintainer approves them. This flow is already different from the original issue. Therefore, I can't reproduce the same behaviour.

Unless I could "bypass" that restriction and have all actions run when I create a PR, I won't be able to validate they consistently run in all cases. I guess only a maintainer could try to reproduce this issue now. 🙇‍♂️

[theomelo]

I can still try to help with debugging. Whenever a maintainer creates a PR that doesn't trigger the actions as expected, would you please ping me here (before closing and opening again) so I can check what happens? 🙏

[SleeplessByte]

That action was already on the Repo when that PR was opened, but it wasn't triggered until the PR was reopened, which is weird. This may be a bug on the GitHub side btw!

[junedev]

@theomelo The pipeline does not run if you have never contributed to the repository in the past (to avoid that people misuse the CI runners). Have you tried to forking the repo and then opening a PR against your fork and trying to trigger the format flow there? (Not sure this works though.) If this doesn't work, I don't think you can help with this issue currently.

I also think there is some chance this is a GitHub bug.

[theomelo]

I also believe it's a bug. I forked this repo and created three PRs, but all of them worked as expected. If this ever happens again, would you mind not closing/reopening that same PR but creating another one instead? Just so we can have a history about that issue we can link to a GitHub discussion.

[junedev]

The bug only shows up consistently when using the format comment action we have set up.

[SleeplessByte]

After format we must also reopen the PR, which is by design.

However, I noticed that the format command no longer posts the extra comments (started and finished) because of a token related error. We probably need to update the script.

[SleeplessByte]

I think that most PRs now have this working with the fork caveat still in place.