Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to pnpm, ESLint 9, and helpful output #852

Merged
merged 63 commits into from
Nov 1, 2024
Merged

Switch to pnpm, ESLint 9, and helpful output #852

merged 63 commits into from
Nov 1, 2024

Conversation

SleeplessByte
Copy link
Member

@SleeplessByte SleeplessByte commented Aug 7, 2024 •
edited
Loading

Need to remove the file:../ references once those are merged and deployed

Dependent on releases of
exercism/javascript-lib-static-analysis#41
exercism/eslint-config-tooling#24

github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 7, 2024
View reviewed changes
test/asserts.mjs Dismissed Show dismissed Hide dismissed
test/asserts.mjs Dismissed Show dismissed Hide dismissed
test/asserts.mjs Dismissed Show dismissed Hide dismissed
test/log.test.mjs Dismissed Show dismissed Hide dismissed
@SleeplessByte SleeplessByte added the x:size/large Large amount of work label Aug 7, 2024
@SleeplessByte
Use published packages
da2fa96
@SleeplessByte
Bump version of docker/build-push-action
f1cacb7
@SleeplessByte
Attempt to enable pnpm to read prettier version
4edf1ea
@SleeplessByte
Fix test
1977be3
@SleeplessByte
Try lts/* for .nvmrc
758c1e9
@SleeplessByte
Fix tests
15d214f
@SleeplessByte
Fix unbound variable issue
9c59213
@SleeplessByte
Use pnpm list instead of why
1c7e2b8
@SleeplessByte
Correctly clear cache using store prune
d2df821
@SleeplessByte
Attempt to fix formatting actions
610579a
@SleeplessByte
Disable store prune for now
95dbcf1
@SleeplessByte
Prune dev dependencies
d256a18
@SleeplessByte
Make binaries executable hopefully
1a0623a
@SleeplessByte
Log the .bin folder
fd2e45d
@SleeplessByte
idk?
3a68b3a
@SleeplessByte
Chown it then I guess?
987dcf4
@SleeplessByte
Don't symlink executables
b969755
@SleeplessByte
Attempt to own and execute as appuser
08d2543
@SleeplessByte
Okay later then
80b9027
@SleeplessByte
Remove all changes to ownership for now
fadf724
@SleeplessByte
Print executability
c794d3f
@SleeplessByte
Log more things
6fb51d4
@SleeplessByte
Debug promise
8be3ca6
@SleeplessByte
Hopefully fix the slug issue
273648c
@SleeplessByte
Try alternatives
28b1ea0
@SleeplessByte
Other alternatives
7fff6ef
@SleeplessByte SleeplessByte marked this pull request as ready for review October 18, 2024 17:05
@SleeplessByte SleeplessByte requested a review from a team as a code owner October 18, 2024 17:05
@SleeplessByte
Copy link
Member Author

@exercism/guardians please check this

@SleeplessByte SleeplessByte mentioned this pull request Oct 18, 2024
Open
vaeng
vaeng approved these changes Oct 19, 2024
View reviewed changes
README.md Show resolved Hide resolved
@SleeplessByte SleeplessByte merged commit 9a4050b into main Nov 1, 2024
6 checks passed
@SleeplessByte SleeplessByte deleted the feature/pnpm branch November 1, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaeng vaeng vaeng approved these changes

Assignees
No one assigned
Labels
x:size/large Large amount of work
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SleeplessByte @vaeng