Update Squeaky Clean instructions #2857
Conversation
There was a problem hiding this comment.
Did you mean to update this file? It’s for a different exercise so that’s out of scope most likely.
There was a problem hiding this comment.
I apologize for the confusion. I made this change in a different branch, and I'm not sure how it ended up here. Any suggestions you have would be greatly appreciated. I've learned from this mistake, and I assure you it won't happen again.
| @@ -14,7 +14,8 @@ | |||
| "SleeplessByte", | |||
| "Smarticles101", | |||
| "sshine", | |||
| "Wasy18" | |||
| "Wasy18", | |||
| "jagdishdrp" | |||
There was a problem hiding this comment.
I think this is changing in one of your other PRs. Could you remove this change from this PR?
There was a problem hiding this comment.
I’m not entirely sure how this ended up here, and I apologize for the oversight. I promise it won’t happen again.
| @@ -29,11 +29,14 @@ SqueakyClean.clean("a-bc"); | |||
| ## 3. Convert leetspeak to normal text | |||
|
|
|||
| Modify the (_static_) `SqueakyClean.clean()` method to convert [leetspeak][leet-speak] to normal text. | |||
|
|
|||
| For simplicity we will only be using `4`, `3`, `0`, `1` and `7` from the table. | |||
There was a problem hiding this comment.
The following suggestion is from the discussion in the forum post:
| For simplicity we will only be using `4`, `3`, `0`, `1` and `7` from the table. | |
| For simplicity we will only be replacing 4, 3, 0, 1 and 7 with a, e, o, l, and t, respectively. |
There was a problem hiding this comment.
I have updated this line as suggested by Mr. Donogheue on the forum. I apologize for the earlier mistake. Please let me know if there's anything else you would like me to change.
| @@ -4,7 +4,8 @@ | |||
| ], | |||
| "contributors": [ | |||
| "sanderploegsma", | |||
| "manumafe98" | |||
| "manumafe98", | |||
| "jagdishdrp" | |||
There was a problem hiding this comment.
This should be your Github handle. I'd also like to add mrDonoghue here since they first suggested this change in the forums.
There was a problem hiding this comment.
I am sorry for the oversight. I have added mrDonoghue and arranged the handles in alphabetical order, which was not maintained previously (even before this PR).
There was a problem hiding this comment.
All good, no need to apologize @jagdish-15 ;)
Thanks for making the updates!
|
Thank you so much, @kahgoh! If you come across any contributions that would be a good fit for me, please feel free to tag me on the forum. I’d be glad to work on them and submit a PR! |
pull request
This pull request is aimed at changing the
instructions.mdfor the Squeaky-Clean exercise in the track.Ref- https://forum.exercism.org/t/java-squeaky-clean-unclear-readme/13575
Reviewer Resources:
Track Policies