Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dnd-character: Add test case for ability with lowest number occurring twice #2792

Merged
merged 1 commit into from
May 8, 2024

Conversation

kahgoh
Copy link
Member

@kahgoh kahgoh commented May 5, 2024

pull request

During a mentoring session, I noticed a solution that passed all the existing tests, but would have failed to meet the following example from the instructions. I wonder if it be worth adding a test for it?

3, 5, 3, 4: You discard the 3 and sum 5 + 3 + 4 = 12, which you assign to wisdom.

Note, I have put the PR here instead of the problem specifications because I noticed the Java track already has some tests around the ability method and the only ability test in the spec seems more vague. I think the ability tests we have might be Java specific?


Reviewer Resources:

Track Policies

Copy link
Contributor

github-actions bot commented May 5, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@manumafe98 manumafe98 added the x:size/small Small amount of work label May 7, 2024
@manumafe98
Copy link
Contributor

Maybe it makes more sense to discuss this directly into an issue? how was the student solving the exercise to not meet with that particular test case?

@kahgoh
Copy link
Member Author

kahgoh commented May 7, 2024

@manumafe98
Copy link
Contributor

@manumafe98 I've opened up a post in the forums to discuss: https://forum.exercism.org/t/missing-test-case-for-ability-with-lowest-number-occurring-twice-in-dnd-character/11097

Great! well we will see when it gets some answers!

@ErikSchierboom ErikSchierboom merged commit ec4d1b7 into exercism:main May 8, 2024
5 checks passed
@kahgoh kahgoh deleted the test/dnd-character branch September 18, 2024 04:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants