-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[New exercise]: two-fer #8
Conversation
About the list of arguments, did you try adding an empty list?
I haven't tested it yet, but the |
The CI is set up now so I'd suggest rebasing. The test suite needs to be updated to the new spec. For that, you could look at the leap implementation. |
@meatball133 could you please let me know what is the status of this exercise? The format of test suites has changed, so that part needs to be updated. Also, we agreed on using 1 tab instead of 4 spaces. Do you need any help with these changes? If you're overwhelmed with other tasks, I can take care of this one :) |
@@ -0,0 +1,8 @@ | |||
func no_name_given(solution_script): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Test methods need to start with test_
for the new test runner to pick them up ;)
It is also a standard in GDScript to have 2 empty lines between methods.
Other than this, I think the solution and tests look good 👍
Code good, tests passing ❤️ Thank you for your contribution @meatball133 ! :) |
I implemented an exercise, you can use this for testing.
It did not work for the test-runner, don't know why. Also, there has to be a way for the test runner to not need to give function arguments.