Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New exercise]: two-fer #8

Merged
merged 8 commits into from
Feb 26, 2024
Merged

[New exercise]: two-fer #8

merged 8 commits into from
Feb 26, 2024

Conversation

meatball133
Copy link
Member

I implemented an exercise, you can use this for testing.

It did not work for the test-runner, don't know why. Also, there has to be a way for the test runner to not need to give function arguments.

@pfertyk
Copy link
Contributor

pfertyk commented Jul 20, 2023

About the list of arguments, did you try adding an empty list?

const TEST_CASES = [
	{"test_name": "Test Something", "args": [], "expected": "something"},
]

I haven't tested it yet, but the args get passed to the callv method in Godot, and I would expect it to work with an empty list. However, methods like this often have some issues ;)

@BNAndras
Copy link
Member

The CI is set up now so I'd suggest rebasing. The test suite needs to be updated to the new spec. For that, you could look at the leap implementation.

@pfertyk
Copy link
Contributor

pfertyk commented Feb 10, 2024

@meatball133 could you please let me know what is the status of this exercise? The format of test suites has changed, so that part needs to be updated. Also, we agreed on using 1 tab instead of 4 spaces. Do you need any help with these changes? If you're overwhelmed with other tasks, I can take care of this one :)

@meatball133 meatball133 marked this pull request as ready for review February 12, 2024 19:59
@@ -0,0 +1,8 @@
func no_name_given(solution_script):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test methods need to start with test_ for the new test runner to pick them up ;)

It is also a standard in GDScript to have 2 empty lines between methods.

Other than this, I think the solution and tests look good 👍

@pfertyk
Copy link
Contributor

pfertyk commented Feb 26, 2024

Code good, tests passing ❤️ Thank you for your contribution @meatball133 ! :)

@pfertyk pfertyk merged commit a457ad4 into exercism:main Feb 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants