Swap actual and expected values in tests #66
Conversation
|
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested. If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos. For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping |
[no important files changed]
pfertyk
force-pushed
the
swap-actual-and-expected
branch
from
a7b182f
to
a18f75c
Compare
There was a problem hiding this comment.
Unrelated to this PR, but roughly_equal doesn't seem ergonomic here. The student is expecting two floats to be compared, but the test runner sees these as booleans. So if you fail test_age_on_Earth and the test runner says something like false isn't true, that might be confusing compared to returning "31.68 is not 31.69". That intuitively makes more sense to me so perhaps roughly_equal can log the two values being compared when the comparison is false.
There was a problem hiding this comment.
Good point, thanks! I will create a new GitHub issue for this. Perhaps Godot has some rounding methods that we could use here ;)
This is a follow-up for exercism/gdscript-test-runner#18.
@glaxxie @BNAndras as main contributors, could you please take a look? ;)