Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Godot Engine typing #33

Merged
merged 1 commit into from
Jan 3, 2024
Merged

Conversation

pfertyk
Copy link
Contributor

@pfertyk pfertyk commented Dec 28, 2023

No description provided.

@pfertyk
Copy link
Contributor Author

pfertyk commented Dec 28, 2023

This is weird ... I thought we already added gradual as a valid typing here:
exercism/configlet#842
@ErikSchierboom do I need to update the Configlet action?

@BNAndras
Copy link
Member

BNAndras commented Jan 2, 2024

The CI uses the latest release of configlet, which is 4.0.0-beta.16 from October 2023, but that predates the PR adding gradual. I think you'll need to wait until the next release of configlet, but I'm not privy to when that might be. Perhaps we can push a beta 17 release sooner than later?

@ErikSchierboom
Copy link
Member

Perhaps we can push a beta 17 release sooner than later?

We'll try and release ASAP

@BNAndras
Copy link
Member

BNAndras commented Jan 3, 2024

Beta 17 was released just a few hours ago so I'd try rerunning the CI here.

@pfertyk
Copy link
Contributor Author

pfertyk commented Jan 3, 2024

Yup, now it works! Thank you! :)

@pfertyk pfertyk merged commit 1e6d251 into main Jan 3, 2024
2 checks passed
@pfertyk pfertyk deleted the update-language-typing-in-config branch January 3, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants