Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meetup exercise: off-by-one error #345

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Conversation

glennj
Copy link
Contributor

@glennj glennj commented Sep 19, 2024

For Date.UTC, the month value is a month index. I was not decrementing by one.

Also, changed Date.UTC to new Date to avoid any timezone related issues.

attn: @BNAndras

Copy link

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@glennj
Copy link
Contributor Author

glennj commented Sep 19, 2024

This is a change to the spec, so existing solutions should be re-tested: "yes important files changed"

@BNAndras BNAndras merged commit 13e6aac into exercism:main Sep 19, 2024
4 checks passed
@glennj glennj deleted the meetup-fix branch September 19, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants