Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added 8 new exercises #105

Merged
merged 6 commits into from
Nov 4, 2023
Merged

Conversation

kapitaali
Copy link
Contributor

Hi,

this is my first pull request ever, so if anything goes wrong, that might be the reason.

WHAT HAS BEEN DONE

I have added 8 new exercises to COBOL track: acronym, all-your-base, atbash-cipherr, binary, circular-buffer, complex-numbers, matching-brackets, pascals-triangle.

These exercises have been solved by me, solutions are found in the respective proof.ci.cob files.

WHAT IS MISSING

I could have appreciated some sort of guidelines as to what is expected when doing a pull request, like if you would need just the .cob and .cut files (which the pull request was about to contain before I realized that there were hidden directories with solutions) or do you need a pull request submitter to solve the exercises. I tried to look around and was not able to find anything. Luckily I did them myself.

…, complex-numbers, matching-brackets, pascals-triangle
Copy link

github-actions bot commented Nov 2, 2023

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Nov 2, 2023
@iHiD iHiD reopened this Nov 2, 2023
@ErikSchierboom
Copy link
Member

@kapitaali Thanks for the PR! It's quite a big PR, so it might take a little while for me to review. I'll come back to this later.

@axtens
Copy link
Member

axtens commented Nov 2, 2023

Also reviewing. My first reaction to Acronym is that while the proof.ci.cob may work, it's not particularly idiomatic cobol. If acronym were already a task, then the provided solution would do as a first attempt. I'd then encourage the student to look into better string length routines, use of indexing into strings etc.

@axtens
Copy link
Member

axtens commented Nov 2, 2023

It does, though, raise the question: is the proof.ci.cob supposed to be "good" cobol or just something-that-works?

@ErikSchierboom
Copy link
Member

just something-that-works?

It's this

@ErikSchierboom
Copy link
Member

Wonderful work! There's a couple of things that need to be fixed before this can be merged:

  1. Fix the configlet issue. All of the newly added exercises need to have an entry in the root config.json file's exercises.practice array: https://github.com/exercism/cobol/blob/main/config.json#L29 See https://exercism.org/docs/building/tracks/config-json#h-practice-exercises for more information.
  2. CI needs to be fixed: https://github.com/exercism/cobol/actions/runs/6729910587/job/18291621996?pr=105 It looks like not all of the proofs pass all the tests.

Once these things have been fixed, we can merge this.

Side note: if you'd like to add more exercises after this, I would suggest doing one PR per exercise, as that makes reviewing easier and increases the chance of the PR being merged sooner.

@ErikSchierboom
Copy link
Member

Just one more configlet error:

JSON parsing error:
/home/runner/work/cobol/cobol/exercises/practice/all-your-base/.meta/config.json(21, 1) Error: found trailing comma. } or key/value pair expected

@kapitaali
Copy link
Contributor Author

argh :D

config.json Outdated Show resolved Hide resolved
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You happy with this @axtens?

Copy link
Member

@axtens axtens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am very happy to see the track expanded in this way. I agree with @ErikSchierboom that submitting extra tasks individually does help with the approval process. Apart from that, approved!

@ErikSchierboom ErikSchierboom merged commit 5dedbb7 into exercism:main Nov 4, 2023
2 of 3 checks passed
@ErikSchierboom
Copy link
Member

Merged! Thanks

@kapitaali kapitaali deleted the added-new-exercises branch November 4, 2023 19:37
@iHiD
Copy link
Member

iHiD commented Nov 6, 2023

@kapitaali Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants