Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make jupyter_cache.cache.main import JupyterCacheBase more accessible #29

Closed
chrisjsewell opened this issue Mar 8, 2020 · 2 comments · Fixed by #35
Closed

Make jupyter_cache.cache.main import JupyterCacheBase more accessible #29

chrisjsewell opened this issue Mar 8, 2020 · 2 comments · Fixed by #35
Labels
api Improvements to the API enhancement New feature or request

Comments

@chrisjsewell
Copy link
Member

I assume the main usage point is from jupyter_cache.cache.main import JupyterCacheBase?

👍 (I should probably make this less deep into the package, but I recall there may be an issue to overcome with cyclic dependency)

Originally posted by @chrisjsewell in #16 (comment)
@chrisjsewell chrisjsewell added api Improvements to the API enhancement New feature or request labels Mar 8, 2020
@chrisjsewell chrisjsewell mentioned this issue Mar 8, 2020
Closed
@chrisjsewell
Copy link
Member Author

Note there is already the get_cache method, so the issue might not be necessary?

https://github.com/ExecutableBookProject/jupyter-cache/blob/9a43e299be84ea48733bdaa39a4a733609a722a0/jupyter_cache/cli/utils.py#L12

mentioned in #16 (comment)

@choldgraf
Copy link
Member

I think either one is fine, but whichever one we recommend should be more clearly documented and discoverable 👍

chrisjsewell added a commit that referenced this issue Mar 12, 2020
@chrisjsewell
Move get_cache to top level and cli/utils.py to utils.py
fb2bfa0 
Improves access and fixes #29
@chrisjsewell chrisjsewell linked a pull request Mar 12, 2020 that will close this issue
Add RTD Documentation #35
Merged
chrisjsewell added a commit that referenced this issue Mar 13, 2020
@chrisjsewell
Add RTD Documentation (#35)
4558db8 
Also:

* Move tabulate records code to standalone functions (fixes #27)
* Move `get_cache`  to top level and `cli/utils.py` to `utils.py` (improves access and fixes #29)
* Create .readthedocs.yml
* Add PyPi deployment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api Improvements to the API enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add RTD Documentation executablebooks/jupyter-cache
2 participants
@choldgraf @chrisjsewell