Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: add prefix CLI #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

agoose77
Copy link
Collaborator

@agoose77 agoose77 commented Aug 3, 2022

This PR adds support for specifying the PR tag prefixes by the CLI. For example, I tend to use https://www.conventionalcommits.org/en/v1.0.0/ for my commit / PR titles.

I've tried to make minimal changes, so it might not be as clean as if we were writing this from scratch. Still, I think it's good enough.

Other changes:

  • Don't ignore tags for --all (bugfix?)

@agoose77
Copy link
Collaborator Author

agoose77 commented Aug 3, 2022

@choldgraf can we delete tags.yml? It seems it was never used in the commit that introduced it: fa670a2

@choldgraf
Copy link
Member

This makes sense to me - though I wonder if it would be a better UX if we supported a GitHub activity yaml file where people could specify the prefixes, labels, etc they wanted to use 🤔

Either way that could probably be a follow up issue, but asking in case you think it'd significantly better and with doing here

@agoose77
Copy link
Collaborator Author

agoose77 commented Aug 3, 2022

@choldgraf I thought about that too. I think the answer is yes, although I initially worried about the programmatic UX for this. In fact, it's probably fine. (todo)

@choldgraf
Copy link
Member

Just to clarify here - do you mean you'd like to do that in a different PR?

@choldgraf
Copy link
Member

btw @agoose77 any interest in having maintainer status on this repository so that you can trigger builds, help review/merge other work, etc?

@agoose77
Copy link
Collaborator Author

@choldgraf I would like to say yes, but I think just right now I might struggle to be of too much use. If it's only a small amount of work here and there I'd be happy to help!

@choldgraf
Copy link
Member

No worries @agoose77 - we don't have any "official" team for this repository and so there aren't any "obligations" per se, other than to just generally try to be helpful and try to make this tool as useful as possible. I've added you to maintainer status:

https://github.com/executablebooks/github-activity/invitations

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants