Feature/viscoll #217
Open
Feature/viscoll #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szenzaro
requested changes
Nov 7, 2023
| terms: Array<term> = []; | ||
| Data: any; | ||
|
|
||
| constructor(private http: HttpClient) { } |
There was a problem hiding this comment.
Better
constructor(
...
){
}
Comment on lines
112
to
117
| let observable = this.http.get('./assets/data/visColl.json'); | ||
| observable.subscribe({next: (data:any)=> { | ||
| this.Data=data; | ||
| } | ||
| }); | ||
| observable.subscribe(() => this.assignmentcycle()); |
There was a problem hiding this comment.
Join the two subscribes into one
|
|
||
| assignmentcycle() { | ||
| for (let rectocounter in this.Data.Rectos) { | ||
| let side=JSON.parse(JSON.stringify(this.sampleSide)); |
Comment on lines
149
to
173
| for (let termcounter in this.Data.Terms) { | ||
| let term=JSON.parse(JSON.stringify(this.sampleTerm)); | ||
| term=JSON.parse(JSON.stringify(this.Data.Terms[termcounter])); | ||
| this.terms.push(term); | ||
|
|
||
| for (let quirenumber in term.objects.Group) { | ||
| this.quires[Number(term.objects.Group[quirenumber])-1].terms.push(term); | ||
| }; | ||
|
|
||
|
|
||
| for (let leafnumber in term.objects.Leaf) { | ||
| this.leaves[Number(term.objects.Leaf[leafnumber])-1].terms.push(term); | ||
| }; | ||
|
|
||
|
|
||
| for (let rectonumber in term.objects.Recto) { | ||
| this.rectos[Number(term.objects.Recto[rectonumber])-1].terms.push(term); | ||
| }; | ||
|
|
||
| for (let versonumber in term.objects.Verso) { | ||
| this.versos[Number(term.objects.Verso[versonumber])-1].terms.push(term); | ||
| }; | ||
| } |
| export class vceside { | ||
| sidedata:sidedataType; | ||
| terms:Array<term>; | ||
| constructor(){} |
| memberleaves:Array<vceleaf>; | ||
| quireImg:string; | ||
| terms:Array<term>; | ||
| constructor(){} |
There was a problem hiding this comment.
remove all empty constructors
| terms:Array<term>; | ||
| constructor(){} | ||
| } | ||
| export class term { |
There was a problem hiding this comment.
capitalize every class and interface type names
represents the Vercelli Book
retto -> recto
interface vcefolio -> vceside property foliodata ->sidedata interface foliodataType -> sidedataType interface foliodataParamsType -> sidedataParamsType this.leafs -> this.leaves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.