Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Fix slow greedy match in oneElement #206

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eviltrout
Copy link
Contributor

Having a greedy regexp in oneElement had major performance issues in Chrome when parsing very large inline blocks.

This re-write does not change any functionality but improves this performance issue. Even though I'm submitting it, it was written by @SamSaffron although I touched it up a bit :)

All tests pass, as does all of Discourse's tests and MDTest 1.1

@SamSaffron
Copy link

Test failure looks transient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants