From 1ce8bfe3fc6d4f48cec6c0e2e9581172368f62c2 Mon Sep 17 00:00:00 2001
From: Rudolph Gottesheim <r.gottesheim@midnight-design.at>
Date: Tue, 9 Jul 2024 11:09:44 +0200
Subject: [PATCH] Disallow useless string concatenation (#35)

---
 Eventjet/ruleset.xml                      | 3 ++-
 php-cs-fixer-rules.php                    | 1 +
 tests/fixtures/invalid/useless-concat.php | 5 +++++
 3 files changed, 8 insertions(+), 1 deletion(-)
 create mode 100644 tests/fixtures/invalid/useless-concat.php

diff --git a/Eventjet/ruleset.xml b/Eventjet/ruleset.xml
index 4ecf0a3..30d0245 100644
--- a/Eventjet/ruleset.xml
+++ b/Eventjet/ruleset.xml
@@ -83,13 +83,14 @@
     <!-- Forbid `$this` inside static function -->
     <rule ref="Squiz.Scope.StaticThisUsage"/>
 
-    <!-- Force whitespace before and after concatenation -->
+    <!-- String concatenation -->
     <rule ref="Squiz.Strings.ConcatenationSpacing">
         <properties>
             <property name="spacing" value="1"/>
             <property name="ignoreNewlines" value="true"/>
         </properties>
     </rule>
+    <rule ref="Generic.Strings.UnnecessaryStringConcat"/>
 
     <!-- Forbid spaces in type casts -->
     <rule ref="Squiz.WhiteSpace.CastSpacing"/>
diff --git a/php-cs-fixer-rules.php b/php-cs-fixer-rules.php
index 019859e..395349a 100644
--- a/php-cs-fixer-rules.php
+++ b/php-cs-fixer-rules.php
@@ -64,6 +64,7 @@
     'no_trailing_comma_in_singleline' => true,
     'no_unused_imports' => true,
     'no_useless_else' => true,
+    'no_useless_concat_operator' => true,
     'nullable_type_declaration_for_default_null_value' => true,
     'ordered_imports' => [
         'imports_order' => ['class', 'function', 'const'],
diff --git a/tests/fixtures/invalid/useless-concat.php b/tests/fixtures/invalid/useless-concat.php
new file mode 100644
index 0000000..f817589
--- /dev/null
+++ b/tests/fixtures/invalid/useless-concat.php
@@ -0,0 +1,5 @@
+<?php
+
+declare(strict_types=1);
+
+echo 'a' . 'b';