Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GTK on window #373

Closed
nico-abram opened this issue Nov 26, 2018 · 1 comment
Closed

Use GTK on window #373

nico-abram opened this issue Nov 26, 2018 · 1 comment
Labels
Good First Issue Indicates a good issue for first-time contributors Platform: Windows Priority: Low Type: Maintenance

Comments

@nico-abram
Copy link
Member

nico-abram commented Nov 26, 2018

In theory this would be as simple as:

  • Link GTK on windows (Somehow, ideally add the source in /extern/ and link it with cmake, probably add a .cmake file in /extern/ for it and add it to the main cmake extern file, then maybe add some things in /src/CMakeLists.txt)
  • Include the file in arch_default.h for windows
  • Make LoadingWindowGTK.h try GTK for windows

Then, practically, this might require:

  • Make the loading window use the new layout (full-window image)
  • There might be non cross-platform code in the stepmania gtk window code. Make it portable.

This would allow us to nuke the windows loading window and the thing itself would probably be faster/ more efficient than our raw implementation.

@nico-abram nico-abram added Priority: Low Platform: Windows Good First Issue Indicates a good issue for first-time contributors Type: Maintenance labels Nov 26, 2018
@nico-abram
Copy link
Member Author

Superseded by #1073

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good First Issue Indicates a good issue for first-time contributors Platform: Windows Priority: Low Type: Maintenance
Projects
None yet
Development

No branches or pull requests

1 participant