From b7212d316ae00914ba766ee1855bd8c07d08f182 Mon Sep 17 00:00:00 2001 From: Nicolas Date: Mon, 2 Apr 2018 15:03:22 -0300 Subject: [PATCH] Remove useless unsigned comparisons <0 --- src/ActorMultiVertex.cpp | 2 +- src/ScoreManager.cpp | 3 --- src/ScreenNetSelectBase.cpp | 3 +-- 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/ActorMultiVertex.cpp b/src/ActorMultiVertex.cpp index efdc5ddfc4..ca7433b6fa 100644 --- a/src/ActorMultiVertex.cpp +++ b/src/ActorMultiVertex.cpp @@ -1098,7 +1098,7 @@ class LunaActorMultiVertex: public Luna static size_t QuadStateIndex(T* p, lua_State *L, int pos) { size_t index = IArg(pos)-1; - if(index < 0 || index >= p->GetNumQuadStates()) + if(index >= p->GetNumQuadStates()) { luaL_error(L, "Invalid state index %d.", index+1); } diff --git a/src/ScoreManager.cpp b/src/ScoreManager.cpp index 3a9170bf1e..99d4fe37c4 100644 --- a/src/ScoreManager.cpp +++ b/src/ScoreManager.cpp @@ -453,9 +453,6 @@ void ScoreManager::SortTopSSRPtrs(Skillset ss, const string& profileID) { } HighScore* ScoreManager::GetTopSSRHighScore(unsigned int rank, int ss) { - if (rank < 0) - rank = 0; - if (ss >= 0 && ss < NUM_Skillset && rank < TopSSRs.size()) return TopSSRs[rank]; diff --git a/src/ScreenNetSelectBase.cpp b/src/ScreenNetSelectBase.cpp index dd72f0a8d3..0058b7a50d 100644 --- a/src/ScreenNetSelectBase.cpp +++ b/src/ScreenNetSelectBase.cpp @@ -238,8 +238,7 @@ void ScreenNetSelectBase::Scroll(unsigned int movescroll) { if (NSMAN->IsETTP()) return; - if (scroll+movescroll >= 0 && scroll+movescroll <= m_textChatOutput.lines - SHOW_CHAT_LINES) - if (scroll+movescroll >= 0 && scroll+movescroll <= static_cast(m_textChatOutput.lines - SHOW_CHAT_LINES)) + if (scroll+movescroll <= m_textChatOutput.lines - SHOW_CHAT_LINES) scroll += movescroll; m_textChatOutput.ResetText(); m_textChatOutput.SetMaxLines(SHOW_CHAT_LINES, 1, scroll);