From a29f1e63511c554f3cf41315dca687f3c96fd16a Mon Sep 17 00:00:00 2001 From: "born a rick, raised a morty, died a jerry" Date: Wed, 20 May 2020 13:18:34 -0400 Subject: [PATCH] attempt to solve div/0 coverity defect with asserts --- src/Etterna/Globals/MinaCalc.cpp | 3 ++- src/Etterna/Models/NoteData/NoteData.cpp | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/src/Etterna/Globals/MinaCalc.cpp b/src/Etterna/Globals/MinaCalc.cpp index 44d07bd984..3bc6d0f1f6 100644 --- a/src/Etterna/Globals/MinaCalc.cpp +++ b/src/Etterna/Globals/MinaCalc.cpp @@ -12,6 +12,7 @@ #include #include #include +#include using std::deque; using std::max; @@ -229,7 +230,7 @@ chord_proportion(const vector& NoteInfo, const int chord_size) if (notes == chord_size) chords += notes; } - + assert(taps > 0); return static_cast(chords) / static_cast(taps); } diff --git a/src/Etterna/Models/NoteData/NoteData.cpp b/src/Etterna/Models/NoteData/NoteData.cpp index 40da06679c..8dc6170c9f 100644 --- a/src/Etterna/Models/NoteData/NoteData.cpp +++ b/src/Etterna/Models/NoteData/NoteData.cpp @@ -180,7 +180,7 @@ NoteData::WifeTotalScoreCalc(TimingData* td, int iStartIndex, int iEndIndex) } } } - + ASSERT(taps > 0); return taps * 2; }