diff --git a/src/main/java/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProvider.java b/src/main/java/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProvider.java index 1e899b54..81dd55c9 100644 --- a/src/main/java/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProvider.java +++ b/src/main/java/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProvider.java @@ -46,8 +46,6 @@ @SuppressWarnings({"DuplicatedCode", "Convert2Diamond"}) public final class GradleEnterpriseParametersProvider implements BuildParametersProvider { - private static final String OVERRIDE_STRING = "UNDEFINED"; - @NotNull @Override public Map getParameters(@NotNull SBuild build, boolean emulationMode) { @@ -73,9 +71,7 @@ public Map getParameters(@NotNull SBuild build, boolean emulatio } private static void setParameter(String key, String value, Map params) { - if (params.containsKey(key) && OVERRIDE_STRING.equals(value)) { - params.remove(key); - } else if (value != null) { + if (value != null) { params.put(key, value); } } diff --git a/src/test/groovy/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProviderTest.groovy b/src/test/groovy/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProviderTest.groovy index dc0c41e4..d0ddb23e 100644 --- a/src/test/groovy/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProviderTest.groovy +++ b/src/test/groovy/nu/studer/teamcity/buildscan/connection/GradleEnterpriseParametersProviderTest.groovy @@ -162,16 +162,4 @@ class GradleEnterpriseParametersProviderTest extends Specification { parameters.get(GRADLE_ENTERPRISE_URL_CONFIG_PARAM) == value } - def "clears configuration parameter when UNDEFINED is passed"() { - given: - descriptorParams[GRADLE_ENTERPRISE_URL] = 'UNDEFINED' - higherDescriptorParams[GRADLE_ENTERPRISE_URL] = 'https://ge.example.invalid' - - when: - def parameters = buildParametersProvider.getParameters(sBuild, false) - - then: - parameters.get(GRADLE_ENTERPRISE_URL_CONFIG_PARAM) == null - } - }