Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why you use diffsusion's q_sample instead of adding noise directly to the input? (DRM.py) #3

Open
ChoiDae1 opened this issue Aug 7, 2023 · 0 comments

Comments

@ChoiDae1
Copy link

ChoiDae1 commented Aug 7, 2023

Hello!
I have one question about your implemtation code.

In DRM.py, I understand DiffusionRobustModel's denoise function plays the role of both noising input image (by using predicted timestep) and denoising.

But, in general certify scheme, input image is first augmented by directly adding noise and then passed classifier.
So, I think below procedure is more correct.

Given sigma,
add noise to input image by directly using this sigma   -> denoisng this input by using predicted timestep

In your implementation, noise-level is influenced by predicted time step. This means you use estimated sigma(not given sigma) for noising input.

If not, please explain about this.
Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant