Skip to content
This repository has been archived by the owner on Aug 2, 2021. It is now read-only.

swap: remove honeyOracle #2132

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

swap: remove honeyOracle #2132

wants to merge 3 commits into from

Conversation

ralph-pichler
Copy link
Member

@ralph-pichler ralph-pichler commented Mar 7, 2020

This PR removes the honeyOracle which was supposed to convert from honey to ether. As honey is now its own token it can be removed.

This PR still keeps the cheque.Honey field. This could also be removed now.

@ralph-pichler ralph-pichler self-assigned this Mar 7, 2020
@ralph-pichler ralph-pichler mentioned this pull request Mar 7, 2020
3 tasks
@ralph-pichler ralph-pichler requested a review from Eknir March 8, 2020 14:22
@mortelli mortelli added the cleanup code completion, add comments and more label Mar 12, 2020
Copy link
Contributor

@mortelli mortelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thanks for doing this cleanup

swap/cheque.go Outdated Show resolved Hide resolved
@acud
Copy link
Member

acud commented Apr 1, 2020

needs a rebase/pull master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cleanup code completion, add comments and more incentives ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants