Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

responsible neighborhood splitting #4758

Open
istae opened this issue Aug 13, 2024 · 0 comments
Open

responsible neighborhood splitting #4758

istae opened this issue Aug 13, 2024 · 0 comments

Comments

@istae
Copy link
Member

istae commented Aug 13, 2024

Background

Swip ethersphere/SWIPs#43

When the reserve capacity is reached, the reserve will go through an eviction process staring with lower value batches first by removing chunks with proximity order less than the storage radius until the size falls below the capacity.

If the size is still over the capacity, the storage radius is increased, and the eviction process repeats again, this time with a higher proximity order criteria.

When the radius increases, the neighborhood actually splits into two. If there is an insufficient number of nodes OR the overlay addresses, after the radius increase, all end of falling into the same neighborhood, the other neighborhood will have no nodes in it and this can cause loss of data for previously stored and newly uploaded chunks.

In the diagram below, imagine the case all nodes in neighborhood 7 share one higher order of proximity, so they all end up in neighborhood 9 after the radius is increased, leaving 4 without a single node.

0ZXSz

Task

  1. Before increasing the storage radius, the node will first check that the two neighborhoods after splitting the current one will have at least have one node. If not, then the radius increase will be skipped.
  2. In the case that there isn't sufficient number of peers, the pullsync worker will be paused and the pushsync will reject new chunks that it stores
  3. The pullsync and pushsyns protocols, if paused, will monitor topology changes and remain paused until the neighborhood split problem is resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant