You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Most of the python codebase is using the standard pep8 variable naming convention with a few exceptions. We'll need to look at and decide whether it makes sense to conform to this for all variables throughout the codebase.
In this recent PR, a couple variables used in filtering (fromBlock and toBlock) were considered for refactoring into snake_case names. As the request is constructed, the filter arguments can be adapted to the appropriate naming convention so that the code itself has no concern with how the requests look.
How can it be fixed?
As a result of this thread, we will agree on the conventions we would like to proceed with. Refactoring can proceed as necessary for the v7 release.
The text was updated successfully, but these errors were encountered:
What was wrong?
Most of the python codebase is using the standard pep8 variable naming convention with a few exceptions. We'll need to look at and decide whether it makes sense to conform to this for all variables throughout the codebase.
In this recent PR, a couple variables used in filtering (
fromBlock
andtoBlock
) were considered for refactoring into snake_case names. As the request is constructed, the filter arguments can be adapted to the appropriate naming convention so that the code itself has no concern with how the requests look.How can it be fixed?
As a result of this thread, we will agree on the conventions we would like to proceed with. Refactoring can proceed as necessary for the v7 release.
The text was updated successfully, but these errors were encountered: