Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Variables in code should follow standard conventions #3085

Closed
Tracked by #2854
reedsa opened this issue Aug 25, 2023 · 2 comments · Fixed by #3353
Closed
Tracked by #2854

Variables in code should follow standard conventions #3085

reedsa opened this issue Aug 25, 2023 · 2 comments · Fixed by #3353
Labels
v7 breaking changes considered for v7

Comments

@reedsa
Copy link
Contributor

reedsa commented Aug 25, 2023

What was wrong?

Most of the python codebase is using the standard pep8 variable naming convention with a few exceptions. We'll need to look at and decide whether it makes sense to conform to this for all variables throughout the codebase.

In this recent PR, a couple variables used in filtering (fromBlock and toBlock) were considered for refactoring into snake_case names. As the request is constructed, the filter arguments can be adapted to the appropriate naming convention so that the code itself has no concern with how the requests look.

How can it be fixed?

As a result of this thread, we will agree on the conventions we would like to proceed with. Refactoring can proceed as necessary for the v7 release.

@reedsa reedsa added Pending Clarification v7 breaking changes considered for v7 labels Aug 25, 2023
@rarjun7777
Copy link

I would like to work on this .

@reedsa
Copy link
Contributor Author

reedsa commented Aug 28, 2023

@rarjun7777 this thread started as one possible approach. Another suggestion is to handle both cases as mentioned in #2787

Not sure which the team is going to decide but will be something to address for v7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v7 breaking changes considered for v7
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants