Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use AcceptQueue for State subnetwork #1486

Open
morph-dev opened this issue Sep 25, 2024 · 0 comments
Open

Don't use AcceptQueue for State subnetwork #1486

morph-dev opened this issue Sep 25, 2024 · 0 comments
Labels
bug Something isn't working shelf-stable Will not be closed by stale-bot state network Issue related to portal state network

Comments

@morph-dev
Copy link
Collaborator

Using AcceptQueue for State network doesn't work because we can't verify content received that way.

We should either:

  1. accept multiple Offers for the same content in at the same time
    • we might want to limit how many of these we want to process in parallel
    • downside: we potentially receive the same content multiple times
  2. use AcceptQueue but don't ask for the content from fallback peers

I think we should do the first one, but we can refactor AcceptQueue to support this use case. For example, it would be configurable how many entries are "ongoing" and how many are "fallback" and different subnetworks can configure it differently.


Background: #856 (fixed with #1209)

When we receive Offer for content key from a node A, we put it in the AcceptQueue.

If another Offer request comes from other peer (node B), we will reject it but update accept queue such that node B is considered as a fallback.

In case that first request fails (e.g. node A doesn't provide us with content, content validation fails, etc.) we will query content from random fallback peers (e.g. node B).

@morph-dev morph-dev added bug Something isn't working state network Issue related to portal state network shelf-stable Will not be closed by stale-bot labels Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working shelf-stable Will not be closed by stale-bot state network Issue related to portal state network
Projects
None yet
Development

No branches or pull requests

1 participant