Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add additional tests for lib-sourcify #1442

Open
3 tasks
Tracked by #1354
manuelwedler opened this issue Jun 17, 2024 · 0 comments
Open
3 tasks
Tracked by #1354

Add additional tests for lib-sourcify #1442

manuelwedler opened this issue Jun 17, 2024 · 0 comments

Comments

@manuelwedler
Copy link
Collaborator

follow-up of #1429

I found parts of lib-sourcify for which it would be nice to add additional tests. We generally want to increase our test coverage. The following parts need additional tests:

  • The hashFunctions folder has only about 50 % coverage. We should write tests that hash some file with ipfsHash and swarmHash. It should be easy to get a high coverage above 90 % here.
  • SourcifyChain: There is some code regarding contracts created by factories that is uncovered. I specifically mean lines 388 - 417 and 194 - 234. These should be tested.
  • validation.ts and verification.ts: These are quite critical components and they have some functions and rather important branches uncovered. I won't go into details here. I think it would be sufficient to get them at least to 90 % coverage.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant