Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement a way to identify fixtures outside of tests/prague/eip7692_eof_v1 that test EOF #767

Open
marioevz opened this issue Aug 27, 2024 · 2 comments

Comments

@marioevz
Copy link
Member

Raised by @pdobacz in #754 (comment), we need a way to efficiently select tests that verify EOF and are outside of the main tests folder (tests/prague/eip7692_eof_v1) but still produce EOF V1 code.

E.g. tests that use the @pytest.mark.with_all_evm_code_types decorator to automatically fill in both legacy and EOF modes, because these tests remain in the respective EIP folder but also exercise EOF code paths.

@pdobacz
Copy link
Collaborator

pdobacz commented Oct 18, 2024

Hey, do I understand correctly, that before we solve this there is no way to include such tests (EOF-wrapped MCOPY tests for example, as the PR linked) in the eip7692 pre-releases?

Could we just put them under the state_tests/cancun/eip5656_mcopy? as long as they're in the eip7692 pre-release and consumers just run everything in state_tests, and the actual target fork (Osaka) is in the JSON anyway, that could work maybe?

@marioevz
Copy link
Member Author

Could we just put them under the state_tests/cancun/eip5656_mcopy? as long as they're in the eip7692 pre-release and consumers just run everything in state_tests, and the actual target fork (Osaka) is in the JSON anyway, that could work maybe?

Yes I think this could be the quick solution to this, simply fill everything using the Osaka fork.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants