Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix yield statement in test_get_custody_columns #3931

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

jtraglia
Copy link
Member

@jtraglia jtraglia commented Sep 19, 2024

We noticed this error during test generation:

ruamel.yaml.representer.RepresenterError: cannot represent an object: 128

yield 'custody_subnet_count', 'meta', custody_subnet_count

Called here:

yield from _run_get_custody_columns(
spec, rng, node_id=0,
custody_subnet_count=spec.config.DATA_COLUMN_SIDECAR_SUBNET_COUNT)

This was happening because we changed the type of DATA_COLUMN_SIDECAR_SUBNET_COUNT to uint64.

| `DATA_COLUMN_SIDECAR_SUBNET_COUNT` | `128` | The number of data column sidecar subnets used in the gossipsub protocol |

| `DATA_COLUMN_SIDECAR_SUBNET_COUNT` | `uint64(128)` | The number of data column sidecar subnets used in the gossipsub protocol |

The solution is to cast this to a native int type that ruamel understands.

@jtraglia jtraglia merged commit d14fb52 into ethereum:dev Sep 19, 2024
26 checks passed
@jtraglia jtraglia deleted the fix-get-custody-columns-yield branch September 19, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants