Fix yield statement in test_get_custody_columns #3931
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed this error during test generation:
consensus-specs/tests/core/pyspec/eth2spec/test/eip7594/networking/test_get_custody_columns.py
Line 19 in dbc746f
Called here:
consensus-specs/tests/core/pyspec/eth2spec/test/eip7594/networking/test_get_custody_columns.py
Lines 44 to 46 in dbc746f
This was happening because we changed the type of
DATA_COLUMN_SIDECAR_SUBNET_COUNT
touint64
.consensus-specs/specs/_features/eip7594/das-core.md
Line 70 in 423bb4d
consensus-specs/specs/_features/eip7594/das-core.md
Line 70 in dbc746f
The solution is to cast this to a native
int
type that ruamel understands.