Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BLS tests: only keep the Ethereum specific tests #25

Open
mratsim opened this issue Oct 11, 2021 · 1 comment
Open

BLS tests: only keep the Ethereum specific tests #25

mratsim opened this issue Oct 11, 2021 · 1 comment

Comments

@mratsim
Copy link

mratsim commented Oct 11, 2021

The current consensus-spec-tests tarballs (v1.1.2) still include the following tests:

  • aggregate
  • aggregate_verify
  • fast_aggregate_verify
  • sign
  • verify

Those were superseded by https://github.com/ethereum/bls12-381-tests.

Should we remove those and only keep ethereum specific tests in this repo?

  • eth_aggregate_pubkeys
  • eth_fast_aggregate_verify

cc @hwwhww @asanso
@hwwhww
Copy link
Contributor

hwwhww commented Oct 12, 2021

👍 on removing IETF APIs test cases from consensus-spec-tests.
We only have to ensure that the test format is the same for reducing client teams' burden.

@zsluedem zsluedem mentioned this issue Jun 1, 2022
Closed
bors bot pushed a commit to sigp/lighthouse that referenced this issue Oct 12, 2022
@zsluedem
Add a new bls test (#3235)
9f24213 
## Issue Addressed

Which issue # does this PR address?
#2629 

## Proposed Changes

Please list or describe the changes introduced by this PR.

1. ci would dowload the bls test cases from https://github.com/ethereum/bls12-381-tests/
2. all the bls test cases(except eth ones) would use cases in the archive from step one
3. The bls test cases from https://github.com/ethereum/consensus-spec-tests would stay there and no use . For the future , these bls test cases would be remove suggested from ethereum/consensus-spec-tests#25 . So it would do no harm and compatible for future cases.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.


Question: 

I am not sure if I should implement tests about `deserialization_G1`, `deserialization_G2` and `hash_to_G2` for the issue.
macladson pushed a commit to macladson/lighthouse that referenced this issue Jan 5, 2023
@zsluedem @macladson
Add a new bls test (sigp#3235)
f16e455 
## Issue Addressed

Which issue # does this PR address?
sigp#2629 

## Proposed Changes

Please list or describe the changes introduced by this PR.

1. ci would dowload the bls test cases from https://github.com/ethereum/bls12-381-tests/
2. all the bls test cases(except eth ones) would use cases in the archive from step one
3. The bls test cases from https://github.com/ethereum/consensus-spec-tests would stay there and no use . For the future , these bls test cases would be remove suggested from ethereum/consensus-spec-tests#25 . So it would do no harm and compatible for future cases.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.


Question: 

I am not sure if I should implement tests about `deserialization_G1`, `deserialization_G2` and `hash_to_G2` for the issue.
Woodpile37 pushed a commit to Woodpile37/lighthouse that referenced this issue Jan 6, 2024
@zsluedem @Woodpile37
Add a new bls test (sigp#3235)
fcfe010 
## Issue Addressed

Which issue # does this PR address?
sigp#2629 

## Proposed Changes

Please list or describe the changes introduced by this PR.

1. ci would dowload the bls test cases from https://github.com/ethereum/bls12-381-tests/
2. all the bls test cases(except eth ones) would use cases in the archive from step one
3. The bls test cases from https://github.com/ethereum/consensus-spec-tests would stay there and no use . For the future , these bls test cases would be remove suggested from ethereum/consensus-spec-tests#25 . So it would do no harm and compatible for future cases.

## Additional Info

Please provide any additional information. For example, future considerations
or information useful for reviewers.


Question: 

I am not sure if I should implement tests about `deserialization_G1`, `deserialization_G2` and `hash_to_G2` for the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hwwhww @mratsim and others