Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ERC-6734: Move to Review #601

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

Therecanbeonlyone1969
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@eip-review-bot
Copy link
Collaborator

eip-review-bot commented Aug 22, 2024

File ERCS/erc-6734.md

Requires 1 more reviewers from @axic, @g11tech, @SamWilsn, @xinbenlv

@eip-review-bot eip-review-bot changed the title Move ERC 6734 to Status: Review Update ERC-6734: Move to Review Aug 22, 2024
@Therecanbeonlyone1969
Copy link
Contributor Author

@SamWilsn I thought the relative link issue for CVEs had been resolved?!

@SamWilsn
Copy link
Collaborator

SamWilsn commented Sep 3, 2024

That's probably my fault. I'll make sure the linter rules are updated.

Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit I can't comment on directly (and please fix before moving into Last Call): you mention "draft standard" when talking about an EIP. That won't make sense when that EIP moves into Final. EIPs should be written as if they were already Final.


EIP-3220 is Stagnant. You'll need to either remove links to it, or help push it to Review.

Removed mention of EIP-3220
@Therecanbeonlyone1969
Copy link
Contributor Author

Small nit I can't comment on directly (and please fix before moving into Last Call): you mention "draft standard" when talking about an EIP. That won't make sense when that EIP moves into Final. EIPs should be written as if they were already Final.

EIP-3220 is Stagnant. You'll need to either remove links to it, or help push it to Review.

Removed mention of EIP-3220

Copy link
Collaborator

@SamWilsn SamWilsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3220 is still in your requires field. You'll either need to remove it or open a pull request moving 3220 to Review.

@Therecanbeonlyone1969
Copy link
Contributor Author

3220 is still in your requires field. You'll either need to remove it or open a pull request moving 3220 to Review.

Updated requires section.

Copy link

The commit 15c10e7 (as a parent of de53def) contains errors.
Please inspect the Run Summary for details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants