CropBytes CBX Token #917
Merged
CropBytes CBX Token #917
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevcb
commented
Aug 28, 2024
kevcb
commented
- CBX Folder created in data
- data.json added for CBX Token (eth, base)
- logo.svg added for CBX token
- CBX Folder created in data - data.json added for CBX Token - logo.svg added for CBX token
wbnns
requested changes
Aug 28, 2024
There was a problem hiding this comment.
Thanks for the PR! CI is failing and this cannot be merged due to the following issues:
error: CBX on chain ethereum token 0x37fc4b48ce93469dbea9918468993c735049642a has incorrect name. Got CropBytes
error: CBX on chain base token 0xD988824d7fA1998D0ABBab2F79A82aF762886caC has incorrect name. Got CropBytes
The name should be CropBytes rather than CropBytes Token in the metadata. Alternatively, you can override the name in the metadata as described here:
https://github.com/ethereum-optimism/ethereum-optimism.github.io?tab=readme-ov-file#per-token-overrides
Hope that helps! Please let us know once updated and we'll rereview.
"name" in json file updated to "CropBytes"
|
I will be updating the same and pushing it. Thanks |
|
Merge failed. Please see automated check logs for more details. |
nitaliano
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.