chat: New option to completely disable chat #5500
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhansen
force-pushed
the
rhansen-chat
branch
4 times, most recently
from
362d7db
to
2023047
Compare
This isn't strictly necessary, but it improves readability.
This makes it possible to add comments and conditional logic.
to improve readability.
* There's no point in asserting that the Content-Type type is JSON
if it didn't return 200.
* There's no point in asserting JSON body properties if the
Content-Type isn't JSON.
* There's no point in asserting data properties if it returned an
error code.
It doesn't hide: If sticky, it unsticks. Otherwise, it minimizes.
It's unclear why this logic was previously triggered by connection state changes, but it doesn't make sense for it to be there.
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
Any update on this @rhansen ? It seems like this feature is not quite ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5314.