Renaming project from staking_deposit to ethstaker_deposit #60
Conversation
|
Can you run the ci-build workflow in the Actions tab on your personal repo and this branch ( |
README.md
Outdated
| @@ -382,19 +380,19 @@ make build_docker | |||
| Run the following command to enter the interactive CLI: | |||
|
|
|||
| ```sh | |||
| docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/staking-deposit-cli | |||
| docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/ethstaker-deposit-cli | |||
There was a problem hiding this comment.
I think the image name needs to be eth-educators/ethstaker-deposit-cli (from the new DOCKER_IMAGE in Makefile). This will need more tests from #61 .
There was a problem hiding this comment.
Good catch
README.md
Outdated
| ``` | ||
|
|
||
| You can also run the tool with optional arguments: | ||
|
|
||
| ```sh | ||
| docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/staking-deposit-cli new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --folder=<YOUR_FOLDER_PATH> | ||
| docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/ethstaker-deposit-cli new-mnemonic --num_validators=<NUM_VALIDATORS> --mnemonic_language=english --folder=<YOUR_FOLDER_PATH> |
There was a problem hiding this comment.
I think the image name needs to be eth-educators/ethstaker-deposit-cli (from the new DOCKER_IMAGE in Makefile). This will need more tests from #61 .
README.md
Outdated
| ``` | ||
|
|
||
| Example for 1 validator on the [Prater testnet](https://prater.launchpad.ethereum.org/) using english: | ||
|
|
||
| ```sh | ||
| docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/staking-deposit-cli new-mnemonic --num_validators=1 --mnemonic_language=english --chain=prater | ||
| docker run -it --rm -v $(pwd)/validator_keys:/app/validator_keys ethereum/ethstaker-deposit-cli new-mnemonic --num_validators=1 --mnemonic_language=english --chain=prater |
There was a problem hiding this comment.
I think the image name needs to be eth-educators/ethstaker-deposit-cli (from the new DOCKER_IMAGE in Makefile). This will need more tests from #61 .
Ran as suggested: https://github.com/valefar-on-discord/ethstaker-deposit-cli/actions/runs/9408783246 |
Simple find and replace with some manual changes here and there.
Fixes #15