Add parallelism when performing multiple tasks at the same that can benefit from it #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nge command steps
valefar-on-discord
requested changes
May 25, 2024
Co-authored-by: valefar-on-discord <[email protected]>
|
There seems to be a lingering issue with this PR and the unit tests in #49 . Let me fix it before finishing the review. |
…tion-mnemonic command
|
The c35380e commit should fix #49. There seems to be another unit test issue in https://github.com/eth-educators/ethstaker-deposit-cli/actions/runs/9273010996/job/25512131191?pr=48 which need more fixes. |
|
It seems like all remaining issues are fixed. You can have another look @valefar-on-discord . |
valefar-on-discord
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds parallelism using the ProcessPoolExecutor when and where we can benefit from executing multiple tasks on potentially multiple cores. This speeds up keys generation, keystores generation, voluntary exits generation and a bunch of verification especially when multiples are requested. It will default to using number of processors on the machine for the number of workers.
Fixes #40
Introduces #47