-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Common characters being overridden in chinese simplified and chinese Traditional word lists #119
Comments
Not sure what is meant by "hiding it", but happy to get involved in this and do some testing if I have a sample mnemonic. I tested creating a mnemonic with the Chinese Simplified language and restore it, the public key is the same. So maybe only in certain cases that this issue will manifest |
I think this comment here gives a better picture of the overall issue: #142 (comment) |
There was a lot of good comments in #142 about this and how to potentially resolve it. Is there still something confusing about how we should go forward with this @valefar-on-discord ? If not, are you good implementing a solution for this issue? |
Nothing confusing. The original bug report is 100% valid and specificly English/French mnemonic languages have some concerning overlap. It seems to be possible for an English mnemonic to be completely overwritten by French and produce a completely different cryptogrpahic result. The Fix:
I don't believe I have any blockers on handling this besides finding the time but this is my next priority item to look at. |
From ethereum#410
“While going through the code, this code here is causing a problem but hiding it. There are common characters between the 2 word lists and when the map is created in the referenced code, if there is a collision in keys, it is silently overridden to the new file being read. This issue can be seen if the code checks for collision of keys.”
We need to write a test to catch this, and fix the issue.
The text was updated successfully, but these errors were encountered: