pattern.find_matches(tree) or treematcher.find_matches(tree, pattern)?

[jhcepas]

We need to decide what strategy is best (or maybe keep both), and organized the code in treematcher consequently. pros? cons?

p = Tree('(A+,B);') 
t = Tree('((A,B), C);')
treematcher.find_matches(t, p)

p = Tree('(A+,B);') 
t = Tree('((A,B), C);')
p.find_matches(tree)

[jhcepas]

I don't see any clear benefit in option 1, do you?

[dpliakos]

I think the first is unnecessary too.
The only case the first syntax I find it to be worthy is the case that a user is not familiar with OOP and sees function calls "as commands" (like "print ' text text' " ), of course one import (from treematcher import find_matches) will be needed. In that case the call maybe is a bit easier to understand.

The other is shorter and more clear, if you can think in OOP way.

Keeping both may make the tutorials unclear and the intention to help not so experienced users may end up making things more complex (at least when I meet something new I just want to know how to do make it work and stick with it at first), so I suggest to keep only the second.

[jhcepas]

we can maybe keep the algorithm as separate functions (like now) and add methods to the TreePattern class as needed. With the current TreePattern.find_matches method should be enough for now.