Move linking config to NavigationConfig #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 23, 2021 20:17
I will need to split the list in two for split view, and I'd like to put linking config in the same file since they are closely related
Potential conflicts warningThis pull request has changes that are conflicting with the changes in 4 open PRs. #111 Export note by @zecakeh (updated 1 day ago)
#117 Generalize goBack feature for CollectionCreate by @zecakeh (updated 1 hour ago)
#159 Fix NotebookListScreen stuck when Notebook is not found by @zecakeh (updated 1 hour ago)
#161 Highlight active Drawer Item by @zecakeh (updated 9 hours ago)
|
This was referenced Feb 23, 2021
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since those two are closely related and you generally change one with the other.
Based on #163.
Tested on web Firefox Linux