Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show which bookmarks have breakpoints #859

Merged
merged 3 commits into from
Mar 25, 2024
Merged

Conversation

Talndir
Copy link
Contributor

@Talndir Talndir commented Mar 24, 2024

New features:

  • Bookmarks now show their symbol name alongside their address, if it can be found.
  • Bookmarks have the same icons beside them that addresses do in the disassembly view (breakpoint, current instruction, or both).
  • While bookmark view is in focus, "B" will toggle a breakpoint at that address, and "Shift+B" will add a conditional breakpoint.

It's not all done in the optimal way, but I didn't want to change too many things outside of the Bookmark plugin (the only other change I made is a function in the edb::v1 namespace that returns the current instruction pointer address).

@eteran
Copy link
Owner

eteran commented Mar 25, 2024

LGTM, thanks for your contribution!

@eteran eteran merged commit ecfc053 into eteran:master Mar 25, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants