Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CMP0115 warning and use default DEFAULT_PLUGIN_DIR or accept #844

Merged
merged 1 commit into from
Nov 1, 2023
Merged

Fix CMP0115 warning and use default DEFAULT_PLUGIN_DIR or accept #844

merged 1 commit into from
Nov 1, 2023

Conversation

tbhaxor
Copy link
Contributor

@tbhaxor tbhaxor commented Oct 26, 2023

  • In the new version of CMP0115 policy extension must also be provided, there is no version.h in PROJECT_SOURCE_DIRECTORY.
  • Accept the DEFAULT_PLUGIN_DIR during CMAKE configure and use default value to ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/edb, if not provided.

@tbhaxor
Fix CMP0115 warning and use default DEFAULT_PLUGIN_DIR or accept
5d1c48c 
- In the new version of CMP0115 policy extension must also be provided,
  there is no version.h in PROJECT_SOURCE_DIRECTORY.
- Accept the DEFAULT_PLUGIN_DIR during CMAKE configure and use default
  value to ${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}/edb, if not provided.
@eteran
Copy link
Owner

eteran commented Nov 1, 2023

LGTM

@eteran eteran merged commit 64fca61 into eteran:master Nov 1, 2023
2 checks passed
@tbhaxor tbhaxor deleted the cmake-fixes branch November 11, 2023 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tbhaxor @eteran