From 8601c59e0446e0ea5fd56ff4a0eab35e2690dba4 Mon Sep 17 00:00:00 2001 From: Joseph Shearer Date: Thu, 3 Aug 2023 11:13:49 -0400 Subject: [PATCH] fix: Only initialize `shape` and `scratch-shape` if this is a brand new Combiner, otherwise keep the schema around to reduce spurious logging --- crates/derive/src/combine_api.rs | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/crates/derive/src/combine_api.rs b/crates/derive/src/combine_api.rs index 5fdf0fcdd4..d779dc2ba6 100644 --- a/crates/derive/src/combine_api.rs +++ b/crates/derive/src/combine_api.rs @@ -133,14 +133,14 @@ impl cgo::Service for API { self.state = Some(State { combiner, - shape: Shape { - type_: types::INVALID, - ..Default::default() - }, - scratch_shape: Shape { - type_: types::INVALID, - ..Default::default() - }, + shape: self + .state + .as_ref() + .map_or(Shape::invalid(), |state| state.shape.clone()), + scratch_shape: self + .state + .as_ref() + .map_or(Shape::invalid(), |state| state.scratch_shape.clone()), fields_ex, key_ex, uuid_placeholder_ptr,