From 5bfa46f610d81ced7091497813a93de81ec3d113 Mon Sep 17 00:00:00 2001 From: Johnny Graettinger Date: Thu, 7 Mar 2024 16:50:42 +0000 Subject: [PATCH] go/shuffle: lower the read channel capacity Time out and cancel reads after about a couple minutes of inactivity, rather than 35 minutes. --- go/shuffle/read.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/go/shuffle/read.go b/go/shuffle/read.go index d8492194e0..e94e0db045 100644 --- a/go/shuffle/read.go +++ b/go/shuffle/read.go @@ -377,7 +377,7 @@ func (r *read) sendReadResult(resp *pr.ShuffleResponse, err error, wakeCh chan<- var queue, cap = len(r.ch), cap(r.ch) if queue == cap { - r.log(ops.Log_warn, + r.log(ops.Log_debug, "cancelling shuffle read due to full channel timeout", "queue", queue, "cap", cap, @@ -696,8 +696,8 @@ func pickHRW(h uint32, from []shuffleMember, start, stop int) int { } // readChannelCapacity is sized so that sendReadResult will overflow and -// cancel the read after ~35 minutes of no progress (1<<20 + 1<<19 + 1<<18 ... millis). -var readChannelCapacity = 22 +// cancel the read after ~2 minutes of no progress (1<<16 + 1<<15 + 1<<14 ... millis). +var readChannelCapacity = 18 func backoff(attempt int) time.Duration { // The choices of backoff time reflect that we're usually waiting for the