-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decode JS doesn't fully decode #297
Comments
I seem to hit this with any pretokenized file as well. Been seeing it for a while. Starting the Web IDE in chromium browser and triggering the bug:
|
Thanks - it was raw strings. Just fixed this - the github-hosted IDE should have the changes right away |
For long pretokenized files decoding doesn't work still (IIRC I have seen this also before raw strings were introduced). Here's me connecting to my watch and trying to decode "alarm.app.js" that is pretokenized (if it's any help - it doesn't seem to tell very much):
|
Ok, just sorted - it'll now always show you the text view when you click 'decode' - I think it was likely due to having non-ASCII characters in the strings - because the contents of strings don't get decoded. I've now made them decode in a more espruino-y way as well though |
Possibly related to #283, I notice that the Decode JS functionality will occasionally not fully decode JS, for example with
gatthrm
's boot code is always shown with Decode JS, even after clicking Decode JS.To reproduce:
gatthrm.boot.js
) in the Web IDEThe text was updated successfully, but these errors were encountered: