Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New app: Dutch clock #3560

Merged
merged 25 commits into from
Sep 7, 2024
Merged

New app: Dutch clock #3560

merged 25 commits into from
Sep 7, 2024

Conversation

whenlit
Copy link
Contributor

@whenlit whenlit commented Sep 6, 2024

A clock that tells the time the way a Dutch person might answer you if you asked them what time it is. It is configurable in a number of ways.

This is my first contribution here, please do not hesitate to tell me if I'm doing anything wrong.

apps/dutchclock/app.js Outdated Show resolved Hide resolved
apps/dutchclock/app.js Outdated Show resolved Hide resolved
@whenlit whenlit requested a review from thyttan September 6, 2024 21:45
apps/dutchclock/app.js Outdated Show resolved Hide resolved
apps/dutchclock/app.js Outdated Show resolved Hide resolved
@whenlit whenlit requested a review from thyttan September 7, 2024 10:52
@pavelmachek
Copy link
Contributor

I guess 1 version in ChangeLog would be enough for now.

More importantly, we have approxclock already. Should we start somehow merging them before we have czech-clock, french-clock, polish-clock ... etc?

@whenlit
Copy link
Contributor Author

whenlit commented Sep 7, 2024

Hi @pavelmachek, thanks for taking the time to look at this. You're right, the origin story of this particular app may not be interesting to everyone. I pruned the Changelog a bit.

Regarding approxclock et al: I'd be happy to help with some kind of abstraction of approximate clocks (a library? a word-based clock with internationalized rules?) but the main point of this particular clock is not so much about approximateness but more about the idiosyncrasies of the Dutch way of telling time ("it's slightly past ten before half six" (5:21) and such).

@pavelmachek
Copy link
Contributor

Hi! The changelog looks good. If it can't be easily merged, I guess we don't merge, sorry for the noise.

@thyttan
Copy link
Collaborator

thyttan commented Sep 7, 2024

Thanks for the app and the swift communication! Always nice to see new contributors! :)

@thyttan thyttan merged commit e353a4b into espruino:master Sep 7, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants