degree symbol replaced #3461
Merged
degree symbol replaced #3461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.replace('°', ' ');
|
This might be related to recent font changes: #3312 / espruino/EspruinoAppLoaderCore#60 @jordimas / @gfwilliams what do you think? |
|
Just checked into this. The Font used is provided in the file, AntonioMedium - it contains capitals/numbers, but no degree symbol (176) or anything above char code 94 - so I think this is the right solution. I'm honestly not sure if Espruino ever would have properly displayed this in any version, but maybe Locale used to use |
bobrippling
added a commit
that referenced
this pull request
Jun 20, 2024
|
Sounds good, I'll merge. Thanks for the fix @lawern! |
|
Fixes #3128 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the newer espruino versions, the degree symbol is not displayed correctly for the temperature in the clock.
I have therefore replaced it with an apostrophe, as shown in the screenshot.